Project

General

Profile

Bug #3129

RRLP support is broken: signals are not being registered

Added by fixeria 5 months ago. Updated 10 days ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
RRLP
Target version:
-
Start date:
03/31/2018
Due date:
% Done:

100%

Estimated time:
Resolution:
worksforme

Description

While reading the source code, I've found that we have:

void on_dso_load_rrlp(void)
{
    osmo_signal_register_handler(SS_SUBSCR, subscr_sig_cb, NULL);
    osmo_signal_register_handler(SS_PAGING, paging_sig_cb, NULL);
}

but don't call it anywhere, according to `git grep on_dso_load_rrlp`:

include/osmocom/msc/rrlp.h:void on_dso_load_rrlp(void);
src/libmsc/rrlp.c:void on_dso_load_rrlp(void) { ... }

History

#1 Updated by fixeria 5 months ago

Also, probably it would make sense to rename the symbol to sth. like:

msc_rrlp_init();

because we don't actually deal with DSO loading here...

#2 Updated by fixeria 12 days ago

  • Category set to RRLP
  • Status changed from New to Feedback
  • Assignee set to fixeria
  • % Done changed from 0 to 90
  • Resolution set to worksforme

A fix has been submitted: https://gerrit.osmocom.org/10339/
I have also manually tested, and now OsmoMSC sends the position request if configured to do so.

#3 Updated by fixeria 10 days ago

  • Status changed from Feedback to Resolved
  • % Done changed from 90 to 100

Merged, tested - works fine now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)