Project

General

Profile

Bug #3129

RRLP support is broken: signals are not being registered

Added by fixeria about 2 months ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
03/31/2018
Due date:
% Done:

0%

Resolution:

Description

While reading the source code, I've found that we have:

void on_dso_load_rrlp(void)
{
    osmo_signal_register_handler(SS_SUBSCR, subscr_sig_cb, NULL);
    osmo_signal_register_handler(SS_PAGING, paging_sig_cb, NULL);
}

but don't call it anywhere, according to `git grep on_dso_load_rrlp`:

include/osmocom/msc/rrlp.h:void on_dso_load_rrlp(void);
src/libmsc/rrlp.c:void on_dso_load_rrlp(void) { ... }

History

#1 Updated by fixeria about 2 months ago

Also, probably it would make sense to rename the symbol to sth. like:

msc_rrlp_init();

because we don't actually deal with DSO loading here...

Also available in: Atom PDF