Actions
Bug #3109
closedgscon FSM has illegal state transitions
Start date:
03/25/2018
Due date:
% Done:
100%
Spec Reference:
Description
hacking on fsm-to-dot to visualize the gscon FSM, the script noticed two illegal state transitions:
- ERROR: gscon_fsm_active() triggers a transition to ST_ACTIVE, but this is not allowed by the FSM definition
- ERROR: gscon_fsm_wait_ho_compl() triggers a transition to ST_CLEARING, but this is not allowed by the FSM definition
setting to immediate prio since it should be fairly quick to allow these.
Files
Updated by neels about 6 years ago
- File deleted (
bsc_subscr_conn_fsm.c_gscon_fsm_SUBSCR_CONN.dot.png)
Updated by neels about 6 years ago
- File deleted (
bsc_subscr_conn_fsm.c_gscon_fsm_SUBSCR_CONN.dot.png)
Updated by neels about 6 years ago
- File bsc_subscr_conn_fsm.c_gscon_fsm_SUBSCR_CONN.dot.png added
- Description updated (diff)
Updated by neels about 6 years ago
- File deleted (
bsc_subscr_conn_fsm.c_gscon_fsm_SUBSCR_CONN.dot.png)
Updated by dexter about 6 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 100
I have checked this back:
ERROR: gscon_fsm_active() triggers a transition to ST_ACTIVE, but this is not allowed by the FSM definition
I have removed the transition, since we are already in ST_ACTIVE we do not have to change.
ERROR: gscon_fsm_wait_ho_compl() triggers a transition to ST_CLEARING, but this is not allowed by the FSM definition
I have added ST_CLEARING now to the out_state_mask since we have to clear when the handover fails.
Here is a patch to fix the problem:
https://gerrit.osmocom.org/7501 gscon: fix illegal state transitions
Updated by dexter about 6 years ago
- Status changed from In Progress to Resolved
Actions
