Bug #3074
closedbs11_config doesn't build with latest master
100%
Description
Commit 3561bd48976dbee8dbd4659dad15be85a3e79ace in osmo-bsc removed bs11_config binary from being built.
I now tried re-enabling it:
diff --git a/src/utils/Makefile.am b/src/utils/Makefile.am index 0c681a56..71c9b16f 100644 --- a/src/utils/Makefile.am +++ b/src/utils/Makefile.am @@ -22,6 +22,7 @@ noinst_HEADERS = \ $(NULL) bin_PROGRAMS = \ + bs11_config \ isdnsync \ meas_json \ $(NULL)
But it fails with lots of errors:
CCLD bs11_config ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `toss_mgcp_conn': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:220: undefined reference to `mgcp_conn_delete' /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:225: undefined reference to `mgcp_conn_delete' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `gscon_cleanup': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:960: undefined reference to `osmo_sccp_tx_disconn' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `gscon_fsm_init': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:251: undefined reference to `osmo_bsc_sigtran_open_conn' /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:273: undefined reference to `osmo_sccp_tx_disconn' /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:265: undefined reference to `osmo_sccp_tx_disconn' /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:263: undefined reference to `osmo_sccp_addr_dump' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `sigtran_send': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:143: undefined reference to `osmo_bsc_sigtran_send' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `gscon_fsm_wait_ho_compl': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:717: undefined reference to `mgcp_conn_modify' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `gscon_fsm_wait_ass_cmpl': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:506: undefined reference to `mgcp_conn_modify' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `gscon_fsm_wait_mdcx_bts': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:577: undefined reference to `mgcp_conn_create' ../../src/libbsc/libbsc.a(bsc_subscr_conn_fsm.o): In function `gscon_fsm_active': /home/pespin/dev/sysmocom/git/osmo-bsc/src/libbsc/bsc_subscr_conn_fsm.c:343: undefined reference to `mgcp_conn_create' collect2: error: ld returned 1 exit status make[3]: *** [Makefile:578: bs11_config] Error 1 make[3]: Leaving directory '/home/pespin/dev/sysmocom/build/new/tmpdir/osmo-bsc/src/utils' make[2]: *** [Makefile:406: all-recursive] Error 1 make[2]: Leaving directory '/home/pespin/dev/sysmocom/build/new/tmpdir/osmo-bsc/src' make[1]: *** [Makefile:442: all-recursive] Error 1 make[1]: Leaving directory '/home/pespin/dev/sysmocom/build/new/tmpdir/osmo-bsc' make: *** [Makefile:374: all] Error 2
Probably those regressions were added during the same commit which disabled its build.
Updated by pespin about 6 years ago
I submited https://gerrit.osmocom.org/7359 to remove it from debian packages to have OBS jobs running again.
Updated by laforge about 6 years ago
On Sat, Mar 17, 2018 at 08:50:50PM +0000, pespin [REDMINE] wrote:
I submited https://gerrit.osmocom.org/7359 to remove it from debian packages to have OBS jobs running again.
this is not the way to solve this, sorry. As lynxis wrote on IRC, he intends
to look into resolving this tomorrow.
Updated by lynxis about 6 years ago
- % Done changed from 0 to 80
https://gerrit.osmocom.org/#/c/7381/
I can not test it, but it compiles ;).
Can somebody else take over and test it?
Updated by lynxis about 6 years ago
This is only a quick fix. I would suggest, we either drop libbsc.a or define the libbsc.a as library to communicate with BTS. So it can be used by ipaccess-config bs11-config and other utilities.
Updated by laforge about 6 years ago
- Status changed from Feedback to Resolved
- % Done changed from 80 to 100
https://gerrit.osmocom.org/#/c/7460
https://gerrit.osmocom.org/#/c/7461
please keep your tickets up to date!