Bug #3001: OsmoBTS logs CDCX/MDCX at wrong level + wrong format - OsmoBTS - Open Source Mobile Communications

Actions

Copy link

Bug #3001

closed

OsmoBTS logs CDCX/MDCX at wrong level + wrong format

Added by laforge about 6 years ago. Updated about 6 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

dexter

Category:

Target version:

Start date:

02/25/2018

Due date:

% Done:

100%

Spec Reference:

Description

During CRCX/MDCX handling, OsmoBTS currently prints logs like:

DRSL <0000> rsl.c:1540 (bts=0,trx=0,ts=1,ss=0) RSL Tx IPAC_CRCX_ACK (local 127.0.0.1:24842, remote 127.0.0.2:0)
DRSL <0000> rsl.c:2690 (bts=0,trx=0,ts=1,ss=0) Rx RSL IPAC_MDCX
DRSL <0000> rsl.c:1710 connect_ip 750716010 
DRSL <0000> rsl.c:1717 connect_port 53894 
DRSL <0000> rsl.c:1726 speech mode: none
DRSL <0000> rsl.c:1732 payload type: none

Which has the following problems:

several lines instead of one single line for CRCX/MDCX. Use LOGPC or first collect all information before calling LOGP.
NOTICE log level is clearly wrong for the most normal events happening. DEBUG or INFO are ok, but definitely not NOTICE.
IP addresses print as signed integer is totally useless for any human reader

Assigning to dexter who introduced the current log format in Change-Id: Ifaa253e5baed5ca364dfbc046a7cb559f106bfbd

Actions

Copy link

Updated by dexter about 6 years ago

Status changed from New to In Progress
% Done changed from 0 to 100

I have corrected the problem now. See patch https://gerrit.osmocom.org/7064

Actions

Copy link

Updated by dexter about 6 years ago

Log output is now like:

Fri Mar  2 16:07:12 2018 <0000> rsl.c:2487 (bts=0,trx=0,ts=2,ss=0) Handing RLL msg UNIT_DATA_IND from LAPDm to MEAS REP
Fri Mar  2 16:07:12 2018 <0000> rsl.c:2487 (bts=0,trx=0,ts=3,ss=0) Handing RLL msg UNIT_DATA_IND from LAPDm to MEAS REP
Fri Mar  2 16:07:12 2018 <0000> rsl.c:2510 (bts=0,trx=0,ts=3,ss=0) Fwd RLL msg DATA_IND from LAPDm to A-bis
Fri Mar  2 16:07:12 2018 <0000> rsl.c:2699 (bts=0,trx=0,ts=3,ss=0) Rx RSL IPAC_MDCX
Fri Mar  2 16:07:12 2018 <0000> rsl.c:1709 (bts=0,trx=0,ts=3,ss=0) IPAC_MDCX: connect_ip=10.9.1.136 connect_port=14600 speech_mode=0 payload_type=3 
Fri Mar  2 16:07:12 2018 <0000> rsl.c:1540 (bts=0,trx=0,ts=3,ss=0) RSL Tx IPAC_MDCX_ACK (local 10.9.1.136:58714, remote 10.9.1.136:14600)
Fri Mar  2 16:07:12 2018 <0000> rsl.c:2699 (bts=0,trx=0,ts=2,ss=0) Rx RSL IPAC_MDCX
Fri Mar  2 16:07:12 2018 <0000> rsl.c:1709 (bts=0,trx=0,ts=2,ss=0) IPAC_MDCX: connect_ip=10.9.1.136 connect_port=58714 speech_mode=0 payload_type=3 
Fri Mar  2 16:07:12 2018 <0000> rsl.c:1540 (bts=0,trx=0,ts=2,ss=0) RSL Tx IPAC_MDCX_ACK (local 10.9.1.136:14600, remote 10.9.1.136:58714)
Fri Mar  2 16:07:12 2018 <000e> l1sap.c:96 RTP clock out of sync with lower layer: 320 vs 160 (15681->15689)
Fri Mar  2 16:07:12 2018 <0000> rsl.c:2510 (bts=0,trx=0,ts=2,ss=0) Fwd RLL msg DATA_IND from LAPDm to A-bis
Fri Mar  2 16:07:12 2018 <000e> l1sap.c:96 RTP clock out of sync with lower layer: 480 vs 160 (15702->15715)
Fri Mar  2 16:07:12 2018 <0000> rsl.c:2487 (bts=0,trx=0,ts=2,ss=0) Handing RLL msg UNIT_DATA_IND from LAPDm to MEAS REP

Actions

Copy link