Project

General

Profile

Bug #2720

arm build comple crash :arm/convert code

Added by o8ko8k 8 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/07/2017
Due date:
% Done:

100%

Estimated time:
Spec Reference:

Description

when running ./configure --with-neon-vfpv4

There appears to be a leftover endif statement from the move of common convert code.

make3: Entering directory '/home/username/source_code/osmo-trx/Transceiver52M/arm'
CC convert.lo
CPPAS convert_neon.lo
CC convolve.lo
convert.c:57:2: error: #endif without #if
#endif

Also, possibly a left over reference causing compile crash for arm builds

/home/username/source_code/osmo-trx/Transceiver52M/osmo-trx.cpp:453: undefined reference to `convert_init'

osmo-trx.cpp osmo-trx.cpp 13.5 KB missing call to x86 function convert_init() o8ko8k, 12/11/2017 04:33 PM
convert.c convert.c 2.23 KB bad #endif o8ko8k, 12/11/2017 04:33 PM

Related issues

Related to OsmoTRX - Bug #2721: OsmoTRX build verification job for armResolved2017-12-07

History

#1 Updated by laforge 8 months ago

General Note: We should add a compile testing job for osmo-trx on arm in our jenkins.

I've added #2721 for that purpose.

On Thu, Dec 07, 2017 at 04:43:14AM +0000, o8ko8k [REDMINE] wrote:

There appears to be a leftover endif statement from the move of common convert code.

As you appear to have a build (and test?) environment for ARM and have tracked it down
already to that point: Would you mind sending us a patch? Thanks.

#2 Updated by laforge 8 months ago

  • Related to Bug #2721: OsmoTRX build verification job for arm added

#3 Updated by o8ko8k 7 months ago

I'm sorry i don't know how to make a patch. I really appreciate all the work you guys put in. I will learn about patches and help where i can.. in the mean time:

./Transceiver52M/arm/convert.c
line 57
/* #endif I commented this line out */

./Transeiver52M/osmo-trx.cpp
line 453
/* convert_init() i commented this line out too */

#4 Updated by laforge 7 months ago

  • Assignee set to pespin

#5 Updated by pespin 6 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Fixed once these are merged:

remote:   https://gerrit.osmocom.org/5760 arm/convert.c: Fix compilation error
remote:   https://gerrit.osmocom.org/5761 arm/convert.c: Add missing convert_init implementation

#6 Updated by laforge 6 months ago

On Thu, Jan 11, 2018 at 06:19:51PM +0000, pespin [REDMINE] wrote:

Fixed once these are merged:

> remote:   https://gerrit.osmocom.org/5760 arm/convert.c: Fix compilation error
> remote:   https://gerrit.osmocom.org/5761 arm/convert.c: Add missing convert_init implementation
> 

both merged now.

#7 Updated by pespin 6 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)