https://projects.osmocom.org/https://projects.osmocom.org/favicon.ico?16647414092017-12-05T10:55:21ZOpen Source Mobile CommunicationsOsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=65682017-12-05T10:55:21Zmsuraev
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-5 priority-highest closed" href="/issues/2407">Bug #2407</a>: N3101 not implemented in OsmoPCU</i> added</li></ul> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=65712017-12-05T11:11:45Zmsuraev
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-4 priority-2 priority-default" href="/issues/1524">Bug #1524</a>: PACCH on the wrong timeslot</i> added</li></ul> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=80052018-03-03T21:41:49Zlaforge
<ul><li><strong>Priority</strong> changed from <i>Normal</i> to <i>Low</i></li></ul> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=210292021-02-01T13:30:44Zpespin
<ul></ul><p>I just found a tbf.txt explaining the current state machine:</p>
<p><a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/22595">https://gerrit.osmocom.org/c/osmo-pcu/+/22595</a> Move src/tbf.txt to doc/</p> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=212252021-02-08T15:05:26Zpespin
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-1 priority-lowest closed" href="/issues/1756">Bug #1756</a>: regression: "tbf: Add state WAIT_ASSIGN"</i> added</li></ul> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=220032021-04-26T17:49:08Zpespin
<ul><li><strong>Assignee</strong> set to <i>pespin</i></li></ul><p>I will probably work on this prior to improving/adding other features, since it will ease the path to extend code.</p> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=221062021-05-14T16:14:11Zpespin
<ul></ul><p>Initial commit for tbf_state FSM:<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/24235">https://gerrit.osmocom.org/c/osmo-pcu/+/24235</a></p> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=224112021-07-26T16:55:21Zpespin
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>60</i></li></ul><p>I submitted a bunch of patches to start moving TBF_STATE infra to use FSM. Results look promising.</p>
<p>See this one and follow-up patches in gerrit:<br /><a class="external" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25011/">https://gerrit.osmocom.org/c/osmo-pcu/+/25011/</a></p> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=224172021-07-29T18:58:25Zpespin
<ul><li><strong>% Done</strong> changed from <i>60</i> to <i>80</i></li></ul><p>I pushed around 30 patches to osmo-pcu in gerrit over last days, doing a huge clean up which will certainly help in maintaining and further improving osmo-pcu:</p>
<p>All patches are available in gerrit as well as in branch "pespin/fsm" of osmo-pcu.git.<br />I have tested them both with unit tests, TTCN3 and manual testing with real phones. No regression observed anywhere.</p>
<pre>
ee0aaf7 Move tbf ul_ack_state to osmocom FSM
6eb8bcf tbf.h: Improve documentation on several flags
39355f2 tbf_dl: Clarify requirements for DL ACK/NACK
f53cca7 Move timer X2002 to tbf_fsm
d858cdf tbf: Use type bool for upgrade_to_multislot
bb48db5 Fix typos in comments documenting fsm st chg macro
d47a4cb tbf: Merge handle_ack_nack() into rcvd_dl_ack()
5f910a4 Get rid of lots of code only used by tests
2d7a610 Move timer X2001 to tbf_fsm
e0220b5 tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_UL_DATA
72e616f tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_DL_ASS
4cf3220 replace dl_ass_state with osmocom FSM
0863d31 tbf: Drop unuseful flag GPRS_RLCMAC_FLAG_TO_UL_ASS
b5924bc tbf: Reimplement rlcmac_diag() and make it available from C
b63421d Replace ul_ass_state with osmocom FSM
4164f6b tbf_free: Get rid of uneeded tbf_state transition
225488a Get rid of tbf_dl:abort()
55979f9 Move rate_ctr free to tbf subclass destructor
cc3f1be Remove duplicate call to gprs_rlcmac_lost_rep
7efe2fb Drop logging last mas report before freeing TBF
ed1c43b Put dl_tbf::cleanup into destructor
e1f3bfd Drop duplicate log line
f261997 Move T3169 and T3195 to tbf_fsm
d99824b Move RELEASING tbf_state transition to tbf_fsm
04d6bae Move WAIT_RELEASE tbf_state transition to tbf_fsm
6996e71 Move FINISHED tbf_state transition to tbf_fsm
0ea6cac tests: tbf: Fix dl_tbf polled for data without being in FLOW state
0ee979a Move FLOW tbf_state transition to tbf_fsm.
710042b Move NULL and ASSIGN tbf_state transition to tbf_fsm
</pre> OsmoPCU - Feature #2709: use osmo_fsm for TBFhttps://projects.osmocom.org/issues/2709?journal_id=227482021-10-15T15:56:35Zpespin
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>80</i> to <i>100</i></li></ul><p>FSMs start to be in good shape in osmo-pcu, and they have been in master branch for a while. Closing this ticket.</p>