Project

General

Profile

Actions

Bug #2535

closed

improve mgcp client API

Added by dexter over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
10/04/2017
Due date:
% Done:

100%

Spec Reference:

Description

The API of the mgcp client is not very optimal designed and we should change it. The problem is that the set of functions that return the generated MGCP message take all parameters separately. MGCP messages have plenty of parameters and when we need one more parameter we have to add another function. I already did this a few times now.

The solution to the problem would be just one (or at least one per message type) generator function that takes a struct. Depending on how the struct is populated the parameter will be included in the MGCP message or not.

Actions #1

Updated by laforge over 6 years ago

Excellent plan, I agree.

Actions #2

Updated by dexter over 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 90

Now we have a unified function to generate all sorts of MGCP messages, see: https://gerrit.osmocom.org/4146

Actions #3

Updated by laforge over 6 years ago

please don't resolve until gerrit patches are merged

Actions #4

Updated by dexter over 6 years ago

  • Status changed from Resolved to In Progress
  • % Done changed from 90 to 100
Actions #5

Updated by dexter over 6 years ago

  • Status changed from In Progress to Resolved
Actions #6

Updated by laforge about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)