Feature #2534
move gsup_client and oap_client code out of osmo-{msc,sgsn}.git
100%
Description
osmo-msc.git and osmo-sgsn.git both use GSUP.
The GSUP protocol definition is in libosmocore already, but both osmo-sgsn and osmo-msc duplicate the gsup_client code.
The gsup_client also depends on oap_client. OAP is currently not used by us but we should keep it active for future use.
gsup_client uses libosmo-abis/ipa as IPA Multiplex implementation.
Hence gsup_client as well as oap_client cannot move to libosmocore, but need to move "at least" to libosmo-abis.
(libosmo-abis/ipa uses libosmocore/gsm/ipa, but the server link code is in libosmo-abis.)
Semantically, libosmo-abis is not the right place for GSUP and OAP: they are not at all related to the Abis interface.
Clarify: what should move where? Then move it to drop the gsup_client code dup between osmo-msc and osmo-sgsn.
Related issues
History
#1 Updated by neels about 1 year ago
- Subject changed from move gsup_client and oap_client to libosmocore to move gsup_client and oap_client code out of osmo-{msc,sgsn}.git
#2 Updated by neels about 1 year ago
- Project changed from libosmocore to Cellular Network Infrastructure
#3 Updated by neels about 1 year ago
- Related to Feature #2528: remove dead code after split from openbsc.git added
#4 Updated by neels about 1 year ago
- Related to Feature #2530: remove dead code after split from openbsc.git added
#6 Updated by laforge 2 months ago
neels wrote:
osmo-hlr.git recently got libosmo-gsup-client -- if a dep of {msc,sgsn} -> osmo-hlr is acceptable, this code could move in there?
yes, that's the point and in fact https://gerrit.osmocom.org/#/c/osmo-sgsn/+/10284/ is a patch for that, but it somehow fails for not-yet-resolved reasons.
#8 Updated by laforge about 2 months ago
- Assignee changed from laforge to msuraev
#9 Updated by laforge about 1 month ago
- % Done changed from 0 to 50
at least for osmo-sgsn, libosmo-gsup-client has just been removed by change-id I6f542945403cf2e3ddac419186b09ec0e2d43b69.
In osmo-msc, it has already been removed as part of change-id I6f542945403cf2e3ddac419186b09ec0e2d43b69 back in July.
This leaves the ticket remaining about oap_client.
#10 Updated by msuraev about 1 month ago
- Status changed from New to In Progress
There's no oap implementation in OsmoSGSN. Related cleanup patch is available in https://gerrit.osmocom.org/#/c/osmo-sgsn/+/11566/
#11 Updated by msuraev about 1 month ago
- Status changed from In Progress to Resolved
- % Done changed from 50 to 100
OAP client was removed from OsmoMSC some time ago already.
