Project

General

Profile

Actions

Bug #2337

closed

OsmoBTS -p param (dsp-trace) still in help message

Added by pespin almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
06/22/2017
Due date:
% Done:

100%

Spec Reference:

Description

In src/osmo-bts-sysmo/main.c, --help command says:

    printf(
        "  -p    --dsp-trace    Set DSP trace flags\n" 
        "  -w    --hw-version    Print the targeted HW Version\n" 
        "  -M    --pcu-direct    Force PCU to access message queue for " 
            "PDCH dchannel directly\n" 
          );

But actually the -p --dsp-trace command doesn't seem to be implemented:

    while (1) {
        int option_idx = 0, c;
        static const struct option long_options[] = {
            /* specific to this hardware */
            { "hw-version", 0, 0, 'w' },
            { "pcu-direct", 0, 0, 'M' },
            { 0, 0, 0, 0 }
        };

        c = getopt_long(argc, argv, "wM",
                long_options, &option_idx);
        if (c == -1)
            break;

        switch (c) {
        case 'M':
            pcu_direct = 1;
            break;
        case 'w':
            print_hwversion();
            exit(0);
            break;
        default:
            num_errors++;
            break;
        }
    }

Either remove the command from the help output or implement the command.

Actions #1

Updated by laforge almost 7 years ago

  • Subject changed from OsmoBTS -p param (dsp-trace) not implemented to OsmoBTS -p param (dsp-trace) still in help message
  • Assignee set to pespin

the dsp-trace-flags command line argument was removed in 9684099ae905e6e61cbc326035d0b37c480f6172, just the help text seems to be stale. Please submit related update.

Actions #2

Updated by pespin over 6 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 90
Actions #3

Updated by laforge over 6 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

patch merged

Actions

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)