Bug #2295
closedOML: Send proper NACK and ALARM messages in case of OML errors
0%
Description
There are cases in which we print a local error message but don't send an OML FOM NACK to the BSC, like when receiving an ARFCN list for frequency hopping in oml_rx_set_radio_attr(). Code needs to be audted fo those and proper error messages sent back to BSC, possibly even together with OML ALERT.
Updated by stsp about 6 years ago
- Status changed from New to In Progress
Related patches:
https://gerrit.osmocom.org/#/c/7882/
https://gerrit.osmocom.org/#/c/7884/
Audit is still on-going.
Updated by stsp about 6 years ago
I cannot find any additional cases in common/oml.c where we're missing an ACK or NACK.
Is there other relevant code I should look at?
If there is not, then in my opinion this ticket can be closed once above patches are merged.
Updated by stsp almost 6 years ago
- Status changed from In Progress to Resolved
Closing this. Please re-open or create a new issue if similar problems are found elsewhere in the code.