Project

General

Profile

Bug #1938

lapd_core human readable connection IDs in debug log

Added by dexter about 4 years ago. Updated 10 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
-
Target version:
-
Start date:
02/03/2017
Due date:
% Done:

100%

Spec Reference:

Description

At the moment we print the pointer address to identify the log lines belonging to a specific connection. Since pointer addresses are difficult to work with, a human readable ID should be printed instead.

e.g. "This is LAPD instance for SAPI3 on bts0/trx1/ts5/lchan3"

This can be implemented by adding a string member to the lapd_datalink struct. The user would set the string to a human readable identifier when the link is created. (See also osmo_fsm).

See also: https://gerrit.osmocom.org/#/c/1724/

Associated revisions

Revision a003fec7 (diff)
Added by laforge 10 months ago

Ensure we include lchan name in all LAPDm log lines

This makes use of the newly-introduced lapdm_channel_init3() API,
which provides the user (BTS in this case) to provide a human-readable
string identifier for each LAPDm channel. This identifier is
subsequently used in all related log lines to provide context.

This means we will now get context information about which specific
SAPI in which sub-channel (ACCH/DCCH) on which lchan/ts/trx/bts a given
message originated from.

Example:
DLLAPD <0011> lapd_core.c:829 ((bts=0,trx=0,ts=0,ss=0)[DCCH][0]) SABM received in state LAPD_STATE_IDLE

Change-Id: I17e3d4797ec71e31d0775330ae36d2e1fd70423f
Depends: libosmocore.git Ie6742843fff809edffcac24c4dce4edf66bc71be
Related: OS#1938

Revision 00b2faf8 (diff)
Added by laforge 10 months ago

lapd/lapdm: print user-defined string name instead of (dl=%p)

At the moment we print the pointer address to identify the log lines
belonging to a specific connection. Since pointer addresses are
difficult to work with, a human readable ID should be printed instead.

e.g. "This is LAPD instance for SAPI3 on bts0/trx1/ts5/lchan3"

Change-Id: Ie6742843fff809edffcac24c4dce4edf66bc71be
Closes: OS#1938

Revision b9031880 (diff)
Added by laforge 10 months ago

lapd: Always print context information when logging

Historically, OpenBSC has primarily been used with setups that have
a single E1 based BTS connected. This meant that an error message on
the E1 LAPD implicitly has to be related to that single BTS.

However, in more comprehensive setups, there may be many BTSs on many
E1 lines with many signaling slots. At this point, it's important to
know which line/timeslot/tei/sapi a given log message relates to.

This patch introduces related log context.

Change-Id: Ib81a749ae24013b17caaf5fd64ccd9acbbc3ce08
Requires: libosmocore.git Change-Id Ie6742843fff809edffcac24c4dce4edf66bc71be
Related: OS#1938

History

#1 Updated by laforge almost 3 years ago

  • Priority changed from Normal to Low

#2 Updated by laforge over 1 year ago

  • Assignee deleted (dexter)

#3 Updated by laforge 12 months ago

#4 Updated by laforge 12 months ago

  • Status changed from New to In Progress
  • Assignee set to laforge

#6 Updated by laforge 10 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 80 to 100

patches all merged now.

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)