Feature #1902
unify/refactor dynamic timeslot code
0%
Description
The two kinds of dynamic timeslots could use the same data structures.
The IPAC style TCH/F_PDCH was implemented first, using ts->flags.
The Osmo style TCH/F_TCH/H_PDCH needed more detailed state, so ts->dyn was added.
The TCH/F_PDCH could also use ts->dyn.
Also, we had neverending bugs of places that forgot to check for dyn ts.
The code would be less fragile if we kept the actual current mode the
timeslot is in in the actual ts->pchan field, where all the code expects it.
Currently we keep "TCH_F_TCH_H_PDCH" in pchan and store the current real
mode in dyn->pchan_is. So all code needs to be aware of dynamic channels
and has to add checks to find out the current mode.
I assume it would be nicer if the fact that a channel is dynamic is kept
in ts->dyn, and the ts->pchan can be evaluated like with static channels.
ts->pchan should probably also reflect switchover as an invalid pchan.
This way all code can just directly use ts->pchan, and the places that
are concerned with switchover can look it up in ts->dyn.*.
Related issues
History
#1 Updated by neels about 2 years ago
- Description updated (diff)
- Priority changed from Normal to Low
(accidentally hit enter when there was no description yet, adding description now)
#2 Updated by neels about 2 years ago
- Assignee set to Osmocom Developers
#3 Updated by laforge about 1 year ago
- Project changed from OpenBSC to OsmoBSC
#4 Updated by laforge about 1 year ago
- Assignee changed from Osmocom Developers to sysmocom
- Priority changed from Low to Normal
I think this should be done together with the introduction of osmo_fsm for handling a lchan, i.e. one FSM per lchan whihc then tracks all of it's activation/deactivation state.
#9 Updated by neels 6 months ago
- Status changed from New to Resolved
In the course introducing the new timeslot FSM in osmo-bsc, the dynamic timeslot handling has been overhauled, and both dyn ts kinds now use the same data structures, namely
- ts.pchan_from_config = vty config setting,
- .pchan_on_init = same as pchan_from_config but is not affected by telnet vty changes, and
- .pchan_is = the current actual pchan.
- For static timeslots, pchan_is = pchan_on_init,
- for dynamic ones,
- pchan_on_init = {TCH_F_TCH_H_PDCH, TCH_F_PDCH}
- pchan_is = {TCH_F, TCH_H, PDCH, NONE}
However, the osmo-bts code base still employs the old separate data structures to track the dynamic timeslot status.
