Feature #1533

Separate the window handling from the TBF more clearly

Added by zecke over 3 years ago. Updated about 2 years ago.

Target version:
Start date:
Due date:
% Done:


Spec Reference:


**The window handling can be more clearly separated from the TBF. This includes clean-ups to the ::assemble_forward_llc. The general multitude of calling dir.dl.window.m_v_b anddir.dl.window.increment_send.

Related issues

Related to OsmoPCU - Bug #1759: Wrong calculation of DL window size for DL assignmentStalled06/28/2016


#1 Updated by zecke over 3 years ago

From Jacob:

The situation has much improved with the edge related update of the window handling, but the update functions in the TBF and RLC window class haven't changed really.
The RBB layout is fully abstracted in decoding.cpp now, only a bitvec and the first BSN are passed around.

#2 Updated by zecke over 3 years ago

  • Priority changed from Normal to Low

#3 Updated by msuraev over 2 years ago

  • Status changed from New to Feedback

I'm not quite sure what else can be done in here. The "window.m_v_b" is used in tbf_dl.cpp only and half of the time is in analyse_errors() functions to obtain stats data, increment_send() is used only once. It's also unclear which are the "update functions in the TBF" referred to in comments. I think we should either have much clearer description with actionable steps or close this altogether.

#4 Updated by msuraev about 2 years ago

  • Assignee changed from msuraev to zecke

#5 Updated by msuraev almost 2 years ago

  • Related to Bug #1759: Wrong calculation of DL window size for DL assignment added

Also available in: Atom PDF

Add picture from clipboard (Maximum size: 48.8 MB)